feat(web): 优化适配器异常时的页面错误信息展示 #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6eeaaf1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ddadaal
requested changes
Apr 3, 2024
pkuhpc-review-bot
bot
added
Code-ChangeRequested
and removed
Code-ReviewRequested
pkuhpc-review-bot
bot
added
Code-ReviewRequested
ddadaal
approved these changes
Apr 8, 2024
|
|
||
| export const ADAPTER_CALL_ON_ONE_ERROR = "ADAPTER_CALL_ON_ONE_ERROR"; | ||
|
|
||
| export const callOnOne: CallOnOne = async (cluster, logger, call) => { |
pkuhpc-review-bot
bot
added
Code-Approved
pkuhpc-review-bot
bot
added
E2E-ReviewRequested
lyl-available
approved these changes
Apr 11, 2024
pkuhpc-review-bot
bot
added
E2E-Approved
ddadaal
pushed a commit
that referenced
this pull request
May 29, 2024
**问题背景** 在适配器异常时页面统一错误处理的issue中 #1182 如果已经是处理封装过的`grpc error`， 会在 `callOnOne`执行时统一处理为 `code = status.INTERNAL`的错误且将errorObject直接写入details，导致部分页面出现 适配器的错误信息详细变为嵌套型对象，无法正确解析  **修改** 统一错误处理时 判断callOnOne返回的error类型，如果是已处理过的grpc error直接抛出错误 **修改后** 前端页面可以正确获取已处理的grpc error的 code, message等，正确显示前端对应的错误信息 统一错误处理也可正常显示   
OYX-1
pushed a commit
that referenced
this pull request
Jul 4, 2024
**问题背景** 在适配器异常时页面统一错误处理的issue中 #1182 如果已经是处理封装过的`grpc error`， 会在 `callOnOne`执行时统一处理为 `code = status.INTERNAL`的错误且将errorObject直接写入details，导致部分页面出现 适配器的错误信息详细变为嵌套型对象，无法正确解析  **修改** 统一错误处理时 判断callOnOne返回的error类型，如果是已处理过的grpc error直接抛出错误 **修改后** 前端页面可以正确获取已处理的grpc error的 code, message等，正确显示前端对应的错误信息 统一错误处理也可正常显示   
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景
适配器或调度器出现异常导致适配器接口请求无法正常发起的情况，大部分页面仍然报错
500 undefined做了什么
此PR主要修改了适配器异常请求无法连接的时候的页面错误处理
在门户系统增加全局错误处理，优化管理系统全局错误处理
门户系统适配器异常时示例
对于页面已单独处理过的500请求报错信息保持原有样式
管理系统适配器异常时示例
多集群同步操作：
单集群操作：
此PR针对适配器异常情况，优化处理各接口页面报错信息，具体接口及特殊情况备注如下
