fix(portal): 作业提交页面修复并优化模板时间应用 #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 80dfd36 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ddadaal
requested changes
Jun 18, 2024
pkuhpc-review-bot
bot
added
Code-ChangeRequested
and removed
Code-ReviewRequested
ddadaal
approved these changes
Jun 20, 2024
pkuhpc-review-bot
bot
added
Code-Approved
piccaSun
approved these changes
Jun 20, 2024
OYX-1
pushed a commit
that referenced
this pull request
Jul 4, 2024
 ### 要修复问题 1.从模板值中获取到的时间无法填入 2.因为新增了时间单位，模板文件中保存的只有分钟所以无法换算回分钟以外的单位 <img width="302" alt="1d0a79840fb94fee37610e85dc107bc" src="https://github.com/PKUHPC/SCOW/assets/78541912/0f47fec2-a763-4c91-81a1-dbbe1d67a4ce"> 3.最长运行时间为空时，提示不随中英文切换变动 ### 修复方法 1.增加最长运行时间的时间单位  2.最长运行时间为空时，提示随中英文切换变动  --------- Co-authored-by: Chen Junda <ddadaal@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
要修复问题
1.从模板值中获取到的时间无法填入
2.因为新增了时间单位，模板文件中保存的只有分钟所以无法换算回分钟以外的单位
3.最长运行时间为空时，提示不随中英文切换变动
修复方法
1.增加最长运行时间的时间单位
2.最长运行时间为空时，提示随中英文切换变动