Improved code quality

scripts/icons/checks/checkIconConflicts.ts

@@ -22,7 +22,6 @@ export const check = () => {
 };
 
 const checkFileIcons = () => {
-    const icons = {};
     checkForConflictsInFileIcons('fileExtensions');
     checkForConflictsInFileIcons('fileNames');
 };

scripts/icons/checks/checkIconUsage.ts

@@ -14,8 +14,6 @@ const folderPath = path.join('icons');
  */
 const availableIcons: { [s: string]: string } = {};
 
-const unusedIcons = [];
-
 /**
  * Get all icon file names from the file system.
  */

scripts/preview/preview.ts

@@ -23,7 +23,7 @@ const createHTMLTableHeadRow = (amount: number) => {
 
 const createHTMLTableBodyRows = (items: IconDefinition[][]) => {
     let rows = '';
-    items.forEach((row, i) => {
+    items.forEach(row => {
         const columns = row.map(icon => `
             <td class="icon">
                 <img src="./../../icons/${icon.iconName}.svg" alt="${icon.label}">
@@ -68,7 +68,7 @@ const savePreview = (fileName: string, size: number, icons: IconDefinition[][])
     // create the images
     createScreenshots(filePath, fileName).then(() => {
         console.log(painter.green(`Successfully created ${fileName} preview images!`));
-    }).catch(e => {
+    }).catch(() => {
         throw Error(painter.red(`Error while creating ${fileName} preview images`));
     });
 };

src/commands/iconPacks.ts

@@ -7,7 +7,7 @@ import * as i18n from './../i18n';
 export const toggleIconPacks = () => {
     return getActiveIconPack()
         .then((pack) => showQuickPickItems(pack)
-            .then((value) => handleQuickPickActions(value, pack)));
+            .then((value) => handleQuickPickActions(value)));
 };
 
 /** Get all packs that can be used in this icon theme. */
@@ -21,7 +21,7 @@ export const getAllIconPacks = () => {
     return packs;
 };
 
-/** Show QuickPick items to select prefered configuration for the icon packs. */
+/** Show QuickPick items to select preferred configuration for the icon packs. */
 const showQuickPickItems = (activePack: string) => {
     const packs = [...getAllIconPacks().sort(), 'none'];
     const options = packs.map((pack): vscode.QuickPickItem => {
@@ -32,7 +32,7 @@ const showQuickPickItems = (activePack: string) => {
         return {
             description: packLabel,
             detail: i18n.translate(`iconPacks.${pack === 'none' ? 'disabled' : 'description'}`, packLabel),
-            label: iconPacksDeactivated ? '\u2714' : isPackActive(activePack, pack) ? '\u2714' : '\u25FB'
+            label: iconPacksDeactivated ? '\u2714' : active ? '\u2714' : '\u25FB'
         };
     });
 
@@ -45,7 +45,7 @@ const showQuickPickItems = (activePack: string) => {
 };
 
 /** Handle the actions from the QuickPick. */
-const handleQuickPickActions = (value: vscode.QuickPickItem, activePack: string) => {
+const handleQuickPickActions = (value: vscode.QuickPickItem) => {
     if (!value || !value.description) return;
     const decision = value.description.replace(' + ', '_').toLowerCase();
 

src/commands/index.ts

@@ -46,6 +46,7 @@ export const commands = [
     activateThemeCommand,
     toggleIconPacksCommand,
     changeFolderThemeCommand,
+    toggleFolderColorCommand,
     restoreDefaultConfigCommand,
     hidesExplorerArrowsCommand,
     changeOpacityCommand

src/helpers/changeDetection.ts

@@ -29,7 +29,7 @@ export const detectConfigChanges = () => {
  */
 const compareConfigs = (configs: string[]): Promise<{ updatedConfigs: IconJsonOptions, updatedJSONConfig: IconJsonOptions }> => {
     return getMaterialIconsJSON().then(json => {
-        return configs.reduce((result, configName, i) => {
+        return configs.reduce((result, configName) => {
             // no further actions (e.g. reload) required
             if (/show(Welcome|Update|Reload)Message/g.test(configName)) return result;
 

src/messages/reload.ts

@@ -4,7 +4,7 @@ import * as i18n from './../i18n';
 
 /** User has to confirm if he wants to reload the editor */
 export const showConfirmToReloadMessage = (): Promise<boolean> => {
-    return new Promise((resolve, reject) => {
+    return new Promise((resolve) => {
         // if the user does not want to see the reload message
         if (helpers.getThemeConfig('showReloadMessage').globalValue === false) return;
 

src/messages/update.ts

@@ -10,8 +10,6 @@ export const showUpdateMessage = () => {
     // if the user does not want to see the update message
     if (helpers.getThemeConfig('showUpdateMessage').globalValue !== true) return;
 
-    const config = helpers.getConfig().inspect('workbench.iconTheme');
-
     vscode.window.showInformationMessage(
         i18n.translate('themeUpdated'),
 

src/models/iconConfiguration.ts

@@ -35,9 +35,3 @@ export class IconConfiguration {
         this.options = {};
     }
 }
-
-interface IconDefinition {
-    [definition: string]: {
-        iconPath: string;
-    };
-}

tsconfig.json

@@ -8,7 +8,9 @@
             "dom"
         ],
         "sourceMap": true,
-        "rootDir": "."
+        "rootDir": ".",
+        "noUnusedLocals": true,
+        "noUnusedParameters": true
     },
     "exclude": [
         "node_modules",