Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Provide icons as node_module #1299

Closed
PKief opened this issue Oct 29, 2021 · 7 comments
Closed

[Feature Request] Provide icons as node_module #1299

PKief opened this issue Oct 29, 2021 · 7 comments
Assignees

Comments

@PKief
Copy link
Member

PKief commented Oct 29, 2021

Provide the icon set as package in node_modules

@PKief PKief self-assigned this Oct 29, 2021
@ghost
Copy link

ghost commented Nov 9, 2021

Thank you @PKief

@ghost
Copy link

ghost commented Dec 17, 2021

@PKief what is the timeline on this feature request 🎈😄

@PKief
Copy link
Member Author

PKief commented Dec 17, 2021

As we also got the issue #1327 I also have a use case for this, but there's no timeline for this feature request yet. I was wondering if it's also possible to install the icons via Github dependency like this:

"dependencies" : {
  "vscode-material-icon-theme" : "git://github.com/pkief/vscode-material-icon-theme.git#bf4eab6fd200aa00b05aeb70ada2543806869a8d"
}

Then you'll get something like this and the icons can be loaded from the node_modules:

image

@PKief
Copy link
Member Author

PKief commented Dec 17, 2021

You can also use this to always install the latest version of the repository:

"dependencies" : {
  "vscode-material-icon-theme" : "git://github.com/pkief/vscode-material-icon-theme.git"
}

I mean, an own npm package would be a little bit better, but until we'll have one, this could be a temporary solution.

@ghost
Copy link

ghost commented Dec 18, 2021

@PKief Yes this is a great temporary solution but is there possibility to move them to a specific directory like: <application-name>resources/views/vendor/vscode-material-icon-theme

@ghost
Copy link

ghost commented Dec 18, 2021

Oh wait I can just reference each icon from the node modules folder.

@PKief
Copy link
Member Author

PKief commented Mar 7, 2022

The icon pack is now officially available as npm package 🎉

https://www.npmjs.com/package/material-icon-theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant