New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Gleam icon has the wrong colour and pose #1432
Comments
Thank you for your message! It is not a mistake but it is intentional that all icons from this extension use colors from the Material Design Color Palette. The background is that this way a uniformity and consistency across the icons can be guaranteed and a great contrast between the icons can be provided. For this reason, I implemented a tool to find out the color that looks most similar to the original color, but is still part of the color palette. For the Gleam icon I used the Material Color Converter as well to find the color which fits the best. That no original colors are used here is part of the concept, it's not about taking over the original logos 100% if they don't fit in well - it's partly a compromise. I'd be open to change the icon so that we use the lucy-pink-2.svg file which was suggested by you. I am also more than willing to adjust the color, with the condition that it is part of the color palette. I look forward to your feedback :) |
Thanks for the thoughtful explanation @PKief, we've taken a bit of time to look for some suitable colour options so I'll be listing them here and when we pick one i'll get back to you! New options:
|
Hey @PKief, an update on the colour selection: it seems the consensus is for |
@TanklesXL Thank you for your feedback, I just created a PR with the changes: #1433 |
Oh wow thank you! I was tinkering with the svg a little bit but you did a much better job than I would have! Edit: looks good to go! |
* The Gleam icon has the wrong colour and pose Fixes #1432 * Update gleam icon size
Hi there 馃憢 it was noticed that a gleam icon was recently added to the icon pack.
As such, we were hoping to correct the image used and the colour selected.
The official gleam colour is
#ffaff3
: this can be seen on the gleam website and on the official github linguist colour for the gleam language.The most common image for the gleam mascot Lucy is running (as can be seen on the gleam website), and here is the most likely candidate for the icon with the correct colour and pose in the gleam website repo: https://github.com/gleam-lang/website/blob/main/images/lucy-pink-2.svg
I made this issue to be able to discuss this change before anyone creates any PRs to fix the image or the colour.
I'm just a community member so I'm going to be looping in Gleam's author @lpil on this in case there is any further discussion/elaboration needed.
The text was updated successfully, but these errors were encountered: