Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon Request] qwik #1946

Closed
1 of 2 tasks
PatrickJS opened this issue Apr 17, 2023 · 7 comments · Fixed by #1949
Closed
1 of 2 tasks

[Icon Request] qwik #1946

PatrickJS opened this issue Apr 17, 2023 · 7 comments · Fixed by #1949

Comments

@PatrickJS
Copy link

Icon Type

  • Folder
  • File

Graphic ideas
qwik icon
qwik-logo

Additional context
right now we see react logo for every file

@mallowigi
Copy link

And what should be the extension to detect it?

@PatrickJS
Copy link
Author

PatrickJS commented Apr 18, 2023

yeah good question. they're .tsx files which is default react icon but react doesn't own .tsx

@mallowigi
Copy link

Should be an icon pack then.

@PatrickJS
Copy link
Author

yeah, it would be great to have an icon pack for Qwik.js I think starting out if we had the qwik logo that would help until I can create all the qwik folder icons for an icon pack. For the qwik logo it needs a white border. I'm looking at your docs right now about it

@PatrickJS
Copy link
Author

PatrickJS commented Apr 19, 2023

Screenshot 2023-04-19 at 8 47 23 AM

hmmm I'm not sure if I like the logo with a white border. I might want to experiment with different colors so it makes more sense. I also want to create an icon for each entry file type and folder.

@PKief
Copy link
Member

PKief commented Apr 19, 2023

Screenshot 2023-04-19 at 8 47 23 AM

hmmm I'm not sure if I like the logo with a white border. I might want to experiment with different colors so it makes more sense. I also want to create an icon for each entry file type and folder.

Yeah, I'd be fine with an icon pack, as this is the best solution to have a different icon for the tsx files. And yes, typically, I try to avoid having a white border around an icon. It gives the icon too much attention compared with the other icons in the set.

@PKief PKief linked a pull request Apr 19, 2023 that will close this issue
@PKief
Copy link
Member

PKief commented Apr 19, 2023

I've created a PR for it https://github.com/PKief/vscode-material-icon-theme/pull/1949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants