Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon Request] textlintrc with extension #2012

Closed
1 of 2 tasks
Hiratake opened this issue Jun 23, 2023 · 1 comment · Fixed by #2137
Closed
1 of 2 tasks

[Icon Request] textlintrc with extension #2012

Hiratake opened this issue Jun 23, 2023 · 1 comment · Fixed by #2137
Assignees

Comments

@Hiratake
Copy link

Icon Type

  • Folder
  • File

File Names

  • .textlintrc.js
  • .textlintrc.json
  • .textlintrc.yml
  • .textlintrc.yaml

Additional context
textlint supports the .js, .json, .yml, and .yaml extensions.
https://textlint.github.io/docs/configuring.html#configuration-files

However, only .textlintrc displays icons.

{
name: 'textlint',
fileNames: ['.textlintrc'],
},

I would very much like to contribute to this project. Can I just add the file name to the fileName above?

@PKief PKief self-assigned this Nov 7, 2023
PKief added a commit that referenced this issue Nov 7, 2023
@PKief
Copy link
Owner

PKief commented Nov 7, 2023

@Hiratake Thank you for the suggestion and for your patience. I have created a PR #2137 that will add it for the next update.

PKief added a commit that referenced this issue Nov 22, 2023
* [Icon Request] textlintrc with extension
Fixes #2012

* Add crx file icon

* Update workflow

* Update workflow

* Update workflow

* Update workflow

* Update workflow

* Update workflow

* Update workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants