-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildcard files.association rules do not override specific keys #241
Comments
At first, I like the comparison with a Christmas tree very much 🎄 😉 Problem: If you use the following line in the "material-icon-theme.files.associations" config: "*.md": "document", then only the following part is changed in the material-icons.json file in your extension folder: "fileExtensions": {
"md": "document",
} But the Solution: At the moment your "workaround" is the only way to overwrite these file icons. But I could add the option that the wildcard will overwrite all files. The implementation of this is not a big deal but I was wondering how I could add this option without adding some breaking changes or a complete new settings entry. My idea to solve it, would be an additional character or syntax in the wildcard like an exclamation mark before the asterisk. The exclamation mark would flag this particular file extension to remove all related file names:
What do you think about this concept? Does the exclamation mark represent it well? |
Maybe this wildcard with two asterisks would be better than the exclamation mark: "**.md": "document" I already did some adjustments in the code and it works fine. |
Hmm, well |
@Tyriar I slept on it for a few nights, but I couldn't find another solution that was more intuitive. In my opinion the two asterisks are good enough at the moment. If there could be some issues with this in the future, then we can see further. But for now it should be fine for this kind of purpose. |
@PKief works great 👍 |
I have a related issue with wildcards in the filename. I don't know if I am doing something wrong or I misspelled something. Any help will be appreciated. On the other hand, don't would be better if in the custom filename extenssions we can set a regular expression pattern, and if that pattern matches make the icon override? |
@PCASME Unfortunately this feature is not supported by the VS Code extension API yet (microsoft/vscode#12493). It was already requested for this extension, so I'll keep track of this in issue #198. |
@PKief thanks for your quickly answer. |
@Tyriar With the latest update you can also turn off the lights of the Christmas tree 😉
Preview: Or just "dim" the lights:
Happy styling and coding 👍 |
Hello @PKief ! The file name which contains space does not catch icon association: "material-icon-theme.files.associations":
{
"Journal des Modifications.md": "changelog",
"Registro de Cambios.md": "changelog"
}, I think @Tyriar should review again, making compatible with regex matching and file namespaces. |
@gusbemacbe Currently, there's no support for this! Please check at VS Code if there is already an issue or open one there. |
There are not similar issues, but I decided to leave the new issue there: microsoft/vscode#35350. |
I saw 🎄 lights at the stage of 5-6 Markdown metafiles. |
I want to make the explorer look less like a Christmas tree and one of the ways I want to do this is by using a single icon for all txt/md files. However, when I do this:
Icons with specific icons are not overridden:
I would expect a wildcard to override all of them. I also don't really want to pollute my settings file with what I think is the only workaround:
The text was updated successfully, but these errors were encountered: