Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular folder icon suggestions #350

Open
GoGoris opened this issue Nov 22, 2018 · 8 comments
Open

Angular folder icon suggestions #350

GoGoris opened this issue Nov 22, 2018 · 8 comments

Comments

@GoGoris
Copy link

GoGoris commented Nov 22, 2018

Angular folder icons:

  • pipes (idea: purple folder icon with 'pipe' in bottom right corner?)
  • guards (angular router security, something like a folder icon with shield?)
  • directives
  • providers in ionic (= services icon)

Other folder icons:

  • target (=dist icon)
  • .sonarlint (sonar icon)
  • .settings
  • validators (folder with green checkmark in bottom right corner?)
@GoGoris GoGoris changed the title I would love the following folder icons for Angular: Angular folder icon suggestions Nov 22, 2018
@AnthonyLenglet
Copy link

Would definitely appreciate a folder for pipes, guards and directives at the very leat, there are folders for react, why not angular? 😃

@PKief
Copy link
Owner

PKief commented Nov 27, 2018

Thank you, I'll consider your suggestions. Since the Angular Icons always have been activated by default for this theme, I was a little reluctant with the folder icons for Angular to not scare non-Angular users :) For example is the folder name "services" a very common folder name also in non-Angular projects. I think there're 2 solutions:

  1. let Angular icons activated by default but create common folder icons only (like I did with "services", or "routes")
  2. deactivate Angular icons by default and create more specific Angular folder icons for the Angular icon pack

Point 2 will definitely cause some irritation and people will wonder why some Angular icons have disappeared after such an update. The reason that the Angular icon pack is activated by default can be traced back to the development of this extension. In the beginning there were less icons without folder icons and this problem did not exist yet.

@AnthonyLenglet
Copy link

AnthonyLenglet commented Nov 27, 2018

I would think that 1. is the better choice
I think as a whole general icons are always the way to go with folders, while with file icons, its easier to get more specific about it

@PKief
Copy link
Owner

PKief commented Nov 27, 2018

You're right, I would prefer the 1st solution. I will try to create some general icons also for Angular specific projects in the near future.

@PKief
Copy link
Owner

PKief commented Dec 9, 2018

So far I can provide you the following icons:

angular folder icons

@Tonysmark
Copy link

Love this icon theme : )
image
although, no dirctives folder icon :(

@AnthonyLenglet
Copy link

Love this icon theme : )
image
although, no dirctives folder icon :(

When I last thought about it, I thought that the best icon for a directives folder would maybe be a puzzle piece, since they're small features that can be attached on elements, and you can put as many as you want on one element

@mrmokwa
Copy link

mrmokwa commented Oct 22, 2019

I would love seeing a icon for directives folder too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants