Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme Icon Image List Missing PHP Icon #421

Closed
CyberPunkCodes opened this issue Mar 26, 2019 · 1 comment
Closed

Readme Icon Image List Missing PHP Icon #421

CyberPunkCodes opened this issue Mar 26, 2019 · 1 comment
Assignees

Comments

@CyberPunkCodes
Copy link

The image on the readme showing all the supported files, is missing the php icon.

This image below:

icon list

^^^ No PHP icon

You have it on the screenshot for the folders, but not the files.

It makes it look like you do not support php files.

@CyberPunkCodes CyberPunkCodes changed the title Readme Icon Image List Missing PHP icon Readme Icon Image List Missing PHP Icon Mar 26, 2019
@PKief
Copy link
Member

PKief commented Mar 27, 2019

@WadeShuler thanks for this issue. The problem is that a preview image for the file icons is created, another for the folder icons, but not for icons that are only defined by their language id as it is for PHP. Since the language icons are used for the files, they should also be on this preview image for file icons.

PHP is only part of the language ids in my extension:
https://github.com/PKief/vscode-material-icon-theme/blob/59d9f4382557ac3f8946f8c1bf01ec983b075357/src/icons/languageIcons.ts#L62

I will improve the generation of this image soon 😉

@PKief PKief self-assigned this Mar 27, 2019
@PKief PKief closed this as completed in 05bde2b May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants