Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon Request] GLSL Icons #597

Closed
malte-v opened this issue Dec 27, 2019 · 12 comments · Fixed by #1483
Closed

[Icon Request] GLSL Icons #597

malte-v opened this issue Dec 27, 2019 · 12 comments · Fixed by #1483

Comments

@malte-v
Copy link
Contributor

malte-v commented Dec 27, 2019

I think it would be really cool if we had GLSL icons in this plugin (.vert, .tesc, .tese, .geom, .frag, .comp). There are some designs I could think of:

  • vertex shader -> some points
  • geometry shader -> a triangle
  • fragment shader -> a grid

and maybe reuse the assembly icon for *.spv files.

Having different icons for different shader types would be especially nice, if that isn't too much work. Or we could just have a generic icon for all shaders.

@malte-v
Copy link
Contributor Author

malte-v commented Dec 27, 2019

@Iainmon
Copy link

Iainmon commented Jan 2, 2020

I would really love to see this! It also might be helpful to accommodate the inconsistent shader file extension naming convention.

Examples:

.vs, .vert, .vertexshader
.fs, .frag, .fragmentshader

@FishHawk
Copy link

I'm not an expert in icon design, but I tried a few. Any suggestions?
vert:
vert svg
geom:
geom svg
fram v1:
fram svg
fram v2:
fram_ex svg

@malte-v
Copy link
Contributor Author

malte-v commented Jan 12, 2020

The icons look great, but for what type of shader are the last two icons supposed to be used?

@FishHawk
Copy link

I prefer the second one. Which one do you like?

This was referenced Jan 15, 2020
@HuskyNator
Copy link

HuskyNator commented Jul 5, 2020

Personally dont really like the suggested icons, though I cannot find a preexisting example :/
(Excempting the 'c'ish logo in the 'VScode great icons' extension, which is a bit too vague.)
That said, I would love icons for this! ^^

@Iainmon
Copy link

Iainmon commented Jul 9, 2020

"fram v2" is a really good one. It is a pretty good example of what a fragment shader does

@HuskyNator
Copy link

If i could suggest, maybe make the vertex shader use the same colored squares as the fram examples?

@FishHawk
Copy link

If i could suggest, maybe make the vertex shader use the same colored square

I remeber my idea was to use different colors so that I can distinguish them in the editor at a glance.

It's been a long time and I have finished my shader project. You can change it if you want.

@HuskyNator
Copy link

I'll try it out later tonight, though i must say i'm clueless when it comes to vscode extensions. 😅

@bart-krakowski
Copy link
Contributor

Hi guys!
I have another idea for that. WDYT?
Frame

@PKief
Copy link
Member

PKief commented Aug 30, 2021

@bart-krakowski if you remove the gradient, we could try it. In addition, the color should be from the Material Color Palette. In general, I think it looks nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants