Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSL file extensions #247

Closed
ema2159 opened this issue Mar 13, 2021 · 5 comments
Closed

GLSL file extensions #247

ema2159 opened this issue Mar 13, 2021 · 5 comments

Comments

@ema2159
Copy link
Contributor

ema2159 commented Mar 13, 2021

Similarly to #236, GLSL (OpenGL Shading Language) file extensions are missing, but it's also straightforward to solve. Simply add the following lines to the all-the-icons.el file

    ;; GLSL
    ("\\.glsl$"          all-the-icons-fileicon "opengl"                :face all-the-icons-blue)
    ("\\.vert$"          all-the-icons-fileicon "opengl"                :face all-the-icons-blue)
    ("\\.frag$"          all-the-icons-fileicon "opengl"                :face all-the-icons-blue)
    ("\\.geom$"          all-the-icons-fileicon "opengl"                :face all-the-icons-blue)

I haven't had the time to submit a PR, but you should be able to add it fairly easily.

@wyuenho
Copy link
Collaborator

wyuenho commented Mar 13, 2021

No thank you. The OpenGL logo does not make a very good icon. It's completely illegible in body text sizes.
Also, AFAIK, there are no commonly used icons representing these file types. The closest I can find is material-extensions/vscode-material-icon-theme#597, which is still an open issue.

@wyuenho wyuenho closed this as completed Mar 13, 2021
@ema2159
Copy link
Contributor Author

ema2159 commented Mar 13, 2021

Indeed. I just thought that it was better than nothing. Though exploring the available icons, it seems there's one named vertex-shader which could be used with different colors for representing the different shaders.

@ema2159
Copy link
Contributor Author

ema2159 commented Apr 9, 2021

Coming back to this, what about this solution:
image
It is close to material-extensions/vscode-material-icon-theme#597 that you mentioned.

@wyuenho
Copy link
Collaborator

wyuenho commented Apr 9, 2021

I'd accept that if you open a PR :)

@ema2159
Copy link
Contributor Author

ema2159 commented Apr 9, 2021

Awesome! Here you go #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants