Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new windicss icon #1007

Merged
merged 3 commits into from
Apr 13, 2021
Merged

feat: new windicss icon #1007

merged 3 commits into from
Apr 13, 2021

Conversation

alexanderniebuhr
Copy link
Contributor

we updated our logo

@PKief PKief self-requested a review April 11, 2021 07:24
PKief
PKief reviewed Apr 13, 2021
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexanderniebuhr, I'm still a little bit thinking about merging this right now. At the moment, the windicss website is still using the logo which is represented as an icon in this extension. In addition, the new icon is using some gradients which is not that convenient regarding the Material Design concept of this extension.

@alexanderniebuhr
Copy link
Contributor Author

@PKief thanks for your insight. The Logo will be published on the website the next days, all other places (e.g. GitHub org) are already updated.

I totally agree, with the gradient. I will remove the gradient and make it a solid color (still the shape of the new logo, should be merged after that color change), I will push an update to this PR. :)

@PKief
Copy link
Member

PKief commented Apr 13, 2021

Thank you for your response. Yes, it would be fine without the gradient, thank you.

PKief
PKief requested changes Apr 13, 2021
View reviewed changes
icons/windicss.svg Outdated Show resolved Hide resolved
PKief
PKief approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, it looks great now :)

@PKief PKief merged commit 3c52b3a into material-extensions:master Apr 13, 2021
@alexanderniebuhr alexanderniebuhr deleted the windicss branch April 13, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderniebuhr @PKief