Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XML support for PHP_CodeSniffer ruleset file #1116

Merged
merged 5 commits into from
Jun 25, 2021
Merged

Add XML support for PHP_CodeSniffer ruleset file #1116

merged 5 commits into from
Jun 25, 2021

Conversation

shivapoudel
Copy link
Contributor

@shivapoudel
Copy link
Contributor Author

Closes #1092

@PKief
Copy link
Member

PKief commented Jun 24, 2021

Wouldn't it make more sense to apply the XML file icon for all file names ending with .xml.dist? If yes, you could add this pattern to the fileExtensions-Array of the XML file icon.

We could also think about a complete new icon for all file names ending with .dist.

@shivapoudel
Copy link
Contributor Author

shivapoudel commented Jun 24, 2021

@PKief Did you mean this way?

    {
      name: 'xml',
      fileExtensions: [
        'xml',
        'plist',
        'xsd',
        'dtd',
        'xsl',
        'xslt',
        'resx',
        'iml',
        'xquery',
        'tmLanguage',
        'manifest',
        'project',
        '.xml.dist', // Can  `xml.dist` be used or not?
      ],
      fileNames: ['.htaccess'],
    },

Both yml.dist and xml.dist are often configuration files and we used both in our projects.

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good, but please take a look at my comments.

src/icons/fileIcons.ts Outdated Show resolved Hide resolved
src/icons/fileIcons.ts Outdated Show resolved Hide resolved
@shivapoudel
Copy link
Contributor Author

Fixed 👍

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good additions!

@PKief PKief merged commit 1c386a0 into material-extensions:main Jun 25, 2021
@shivapoudel shivapoudel deleted the patch-3 branch June 25, 2021 08:10
@ghost ghost mentioned this pull request Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants