Add support to plop file icon #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PKief
requested changes
Jan 21, 2022
There was a problem hiding this comment.
The icon looks quite nice, but to be used as icon in the Material Icon Theme it needs some adjustments. To be more consistent with the Material Design of the theme it would be great if you could remove the gradient and pick a color from this color palette. In addition, it would be great to add some space to the top and bottom of the document like this:
…-material-icon-theme into pr/nicolas-justin/1350
PKief
force-pushed
the
main
branch
9 times, most recently
from
c149f3c
to
6ed12b6
Compare
PKief
approved these changes
May 4, 2022
|
Looks good to me, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support to plop file icon.
Preview: