Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve range of language Makefile #1409

Merged
merged 3 commits into from
Mar 6, 2022
Merged

Improve range of language Makefile #1409

merged 3 commits into from
Mar 6, 2022

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Mar 1, 2022 •
edited
Loading

This improves support for Makefiles by using the icon in more contexts where it is applicable

.mk files, Kbuild and GNUMakefile are now all highlighted

In the kernel docs for Kbuild

The above line can be put in either a “Kbuild” file or a “Makefile.”

According to GNU Make's manual

By default, when make looks for the makefile, it tries the following names, in order: GNUmakefile, makefile and Makefile.

In this SO answer

The .mk extension is a more or less standard extension for make files that have other names than the defaults.

@PKief PKief self-requested a review March 5, 2022 20:53
@PKief PKief force-pushed the main branch 2 times, most recently from bc99cbb to 06e9cd2 Compare March 6, 2022 12:54
PKief
PKief approved these changes Mar 6, 2022
View reviewed changes
src/icons/fileIcons.ts Show resolved Hide resolved
@PKief PKief merged commit 53615b9 into material-extensions:main Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyperupcall @PKief @ZetiMente