Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several file extension, file name, and folder name icon associations #1447

Merged
merged 5 commits into from Mar 28, 2022
Merged

Several file extension, file name, and folder name icon associations #1447

merged 5 commits into from Mar 28, 2022

Conversation

maallaard
Copy link
Contributor

@maallaard maallaard commented Mar 27, 2022

Other than some general cleanup, I added some more names for folder and file icons to associate with. This includes a fair amount of abbreviations and pluralizations. The changes are as follows:

File extensions:

  • json5 for json icon
  • ods for table icon
  • bz2 for zip icon
  • odt for word icon
  • odp for presentation icon
  • ron for rust icon (rust object notation)

File names:

  • .gitignore-global for git icon (with hyphen instead of underscore)
  • contributing.md, contributing.rst, contributing.txt, and contributing for contributing icon
  • readme.rst for readme icon
  • changelog.rst, changes.rst, and changes for changelog icon
  • credits.rst for credits icon
  • authors.rst, contributors.md, contributors.rst, contributors.txt, and contributors for authors icon

Folder names:

  • srcs for folder-src icon
  • imgs, icos, screengrab, screengrabs, pic, and pics for folder-images icon
  • jsons for folder-json icon
  • cfg, cfgs, conf, and confs for folder-config icon
  • langs for folder-i18n icon
  • aud and auds for folder-audio icon
  • vid and vids for folder-video icon
  • arc, arcs, bkp, bkps, bak, and baks for folder-archive icon
  • func, funcs, maths, and calcs for folder-functions icon
  • pkgs for folder-packages icon
  • anim and anims for folder-animations icon

I also noticed that musics is a valid name under the folder-audio icon, but since the word 'music' does not have a plural form, 'musics' is not an actual word and should be reverted.

@maallaard maallaard marked this pull request as ready for review March 27, 2022 17:55
Copy link
Owner

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this nice PR! There's only one small issue with the duplicated "changes" file name, see comment.

src/icons/fileIcons.ts Outdated Show resolved Hide resolved
@maallaard maallaard requested a review from PKief March 28, 2022 12:54
src/icons/fileIcons.ts Outdated Show resolved Hide resolved
@maallaard
Copy link
Contributor Author

tests passed, hallelujah

@maallaard maallaard requested a review from PKief March 28, 2022 13:18
@PKief
Copy link
Owner

PKief commented Mar 28, 2022

tests passed, hallelujah

Thank you :)

@PKief PKief merged commit 7e95479 into PKief:main Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants