Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nuxt folder icons #1490

Merged
merged 9 commits into from
Apr 27, 2022
Merged

Update nuxt folder icons #1490

merged 9 commits into from
Apr 27, 2022

Conversation

LukeTimeWalker
Copy link
Contributor

Preview

grafik

Original Image

grafik

Resolves #1489

@PKief PKief self-requested a review April 25, 2022 18:55
PKief
PKief reviewed Apr 25, 2022
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed it and found out that the contrast isn't that satisfying. This is why I played around a little bit and came up with this alternative:

Collapsed Expanded
collapsed nuxt folder iconexpanded nuxt folder icon

Demo together with icon

Demo together with icon

What do you think about it?

@LukeTimeWalker
Copy link
Contributor Author

Yes, I think that's better. And it draws the focus more on the Nuxt icon

@PKief PKief merged commit 4784b5a into material-extensions:main Apr 27, 2022
@LukeTimeWalker LukeTimeWalker deleted the update-nuxt-folder-icons branch August 10, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Icon Request] Update NuxtJS folder icon
2 participants
@LukeTimeWalker @PKief