Feature: added folder icon for Lua language; #1542
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! :)
I noticed there was no language folder for Lua language files, so I added one.
Motivation
I read here (issue #412 comment) that some other people have already asked for other language folder icons, though it didn't really make sense. In general, I agree that people probably don't often have folders named "Java".
But I could think of two use cases:
(This is actually my personal reason for requesting this icon 😊)
For instance, I'm currently learning Lua on exercism, and they divide their courses into "tracks", where each track lets you learn some programming language. I have an "exercism" repository where I solve their challenges, and since the courses are divided by programming language, it makes sense to separate folders in the same way:
This way my "tracks" are beautifully separated 😄
Lua files are often used to add mod scripts to video games. For instance, the popular MMO World of Warcraft allows players to customize their game's User Interface with "addons", and as far as I know these addons are always written in Lua. I can imagine that someone may want to create a "Lua" folder when making such scripts.
Alternatively, someone may just have a "scripts" folder in a regular project (e.g. a Node JS project), where they include scripts in different languages. E.g. they may wish to separate their bash, JS, Python and Lua scripts into separate folders. (Of course, I've never, ever met anyone who needed Lua scripts in their Node projects, but hey, who am I to dictate how people write their code? 😄 Maybe they're more comfortable in Lua than Python / bash? 😄)
For the colors:
Anyhow, I would really appreciate it if these icons could be added 🙂 This would then also be my second contribution to this repo! (About 2 ago I made a PR #793 to add folder icons for Apollo, which I now use in several projects! 😊) So yeah, just wanted to say thanks again, this is an awesome project! 🙂