Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: added folder icon for Lua language; #1542

Merged
merged 1 commit into from
Jun 4, 2022

Conversation

Deckstar
Copy link
Contributor

@Deckstar Deckstar commented May 29, 2022

Hello! :)

I noticed there was no language folder for Lua language files, so I added one.

Motivation

I read here (issue #412 comment) that some other people have already asked for other language folder icons, though it didn't really make sense. In general, I agree that people probably don't often have folders named "Java".

But I could think of two use cases:

  1. Tutorial folders.

(This is actually my personal reason for requesting this icon 😊)

For instance, I'm currently learning Lua on exercism, and they divide their courses into "tracks", where each track lets you learn some programming language. I have an "exercism" repository where I solve their challenges, and since the courses are divided by programming language, it makes sense to separate folders in the same way:

Screenshot 2022-05-29 at 6 53 50 PM

This way my "tracks" are beautifully separated 😄

  1. Script folders.

Lua files are often used to add mod scripts to video games. For instance, the popular MMO World of Warcraft allows players to customize their game's User Interface with "addons", and as far as I know these addons are always written in Lua. I can imagine that someone may want to create a "Lua" folder when making such scripts.

Alternatively, someone may just have a "scripts" folder in a regular project (e.g. a Node JS project), where they include scripts in different languages. E.g. they may wish to separate their bash, JS, Python and Lua scripts into separate folders. (Of course, I've never, ever met anyone who needed Lua scripts in their Node projects, but hey, who am I to dictate how people write their code? 😄 Maybe they're more comfortable in Lua than Python / bash? 😄)


For the colors:

  • for the folder, I used the same color as the Lua language icon
  • for the icon, I used the same icon as the globe from the "public" folder. It seemed like a good fit! 🙂

Anyhow, I would really appreciate it if these icons could be added 🙂 This would then also be my second contribution to this repo! (About 2 ago I made a PR #793 to add folder icons for Apollo, which I now use in several projects! 😊) So yeah, just wanted to say thanks again, this is an awesome project! 🙂

@Deckstar Deckstar mentioned this pull request May 29, 2022
1 task
@PKief PKief linked an issue May 29, 2022 that may be closed by this pull request
1 task
@PKief PKief self-requested a review June 3, 2022 20:38
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the contribution, looks good to me 😅 I can understand your arguments so this is totally fine. My comment was only on an issue where icons for each language were generally requested and that's not really my ambition. But concrete suggestions are always welcome and I like them :)

@PKief PKief merged commit 66df51e into material-extensions:main Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Folder Icon Request] Lua Folder
2 participants