Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jwt folder #1566

Merged
merged 4 commits into from Jul 4, 2022
Merged

feat: jwt folder #1566

merged 4 commits into from Jul 4, 2022

Conversation

bart-krakowski
Copy link
Contributor

@bart-krakowski bart-krakowski commented Jun 14, 2022

This PR introduces the icon for the folder of JWT.
Frame 23

Closes: #1351

@ultram4rine
Copy link

Recursion detected! I think you mean #1351 @bart-krakowski

@PKief PKief self-requested a review July 2, 2022 07:16
Copy link
Owner

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, however I find the icon on the folder icon too colorful. I usually try to make the icons that are on the folder icons one color. They have the same color as the folder icon behind, just a bit lighter. Only in very rare cases I make the icon colored, but only if the color absolutely serves as recognition value. In this case, however, I don't feel that way. Furthermore, it would be good if the icon was not quite so far below the folder icon. It would have to be moved up a bit. I often use this folder icon as a reference: https://github.com/PKief/vscode-material-icon-theme/blob/main/icons/folder-dist.svg.

I also usually try to make the folder colors not stand out as much as file icons. Especially with the jwt-folder-icon it is so that it does not have to stand out incredibly strong, because a jwt is now also not so super important as that it must be so strongly emphasized in the entirety of a project directory.

@bart-krakowski bart-krakowski requested a review from PKief July 2, 2022 12:49
@bart-krakowski
Copy link
Contributor Author

Thanks for your input! I changed colors. What do you think about it now?

jwt

@PKief
Copy link
Owner

PKief commented Jul 4, 2022

Thanks for your input! I changed colors. What do you think about it now?

jwt

Thanks it looks better. Still I think the JWT logo is not a good fit for jwt folder icons. What do you think if we just associate jwt folder with keys folder like shown here:

image

Or maybe also with the tag-icon:

https://materialdesignicons.com/icon/tag

But I'd be fine with the keys folder icon which already exists. So we'd just need to associate it with the "jwt" folder name 🙈

@bart-krakowski
Copy link
Contributor Author

Thanks for your input! I changed colors. What do you think about it now?
jwt

Thanks it looks better. Still I think the JWT logo is not a good fit for jwt folder icons. What do you think if we just associate jwt folder with keys folder like shown here:

image

Or maybe also with the tag-icon:

https://materialdesignicons.com/icon/tag

But I'd be fine with the keys folder icon which already exists. So we'd just need to associate it with the "jwt" folder name 🙈

@PKief, I've removed the JWT icon and associated it with the folder-keys icon.

@PKief PKief merged commit fadd52c into PKief:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request] jwt
3 participants