feat: icons for desktop os

[bart-krakowski]

This PR adds icons for the desktop OSs (Linux, Windows and MacOS).
Closes: #1612

[md-siam]

Still same as before:

[yozachar]

Hi, I want this association too!

Thanks for contributing @bart-krakowski! I tested it, but something's not right.

The folder icons vanish! Where am I going wrong?

cc: @PKief

[PKief]

The proposed icons look quite nice but are not that consistent to the other folder icons in the theme. Usually a folder icon has a colored folder icon with a symbol which has one (!) brighter color. In this PR only the windows icons looks consistent. There are some exceptions, but only if the recognition value would suffer greatly if the symbol were monochrome. For example the aurelia or bower folder icons look really ugly (I created them long time ago and should probably fix them someday 😅). I would not like to deviate from this consistency with new icons.

I will add this rule to the contributions guide very soon, as I see that this is happening quite often 🙈

[yozachar]

@PKief, thanks for the update. So, I hopped on to Figma and did a few tweaks.

	Linux	Windows	MacOS
Close
Open

Are these icons okay? (Open to suggestions!)

---

I use the gruvbox color theme. Setting custom icons on settings.json makes 'em disappear:

    "material-icon-theme.folders.associations": {
        "linux": "../../../../../../../.vscode/extensions/icons/folder-linux",
        "windows": "../../../../../../../.vscode/extensions/icons/folder-windows",
        "macos": "../../../../../../../.vscode/extensions/icons/folder-macos",
    }

But if I change to default dark color theme, the folder icons return, but they remain the default ones. (Should I open an issue?)

[yozachar]

Hi @PKief, I understand it boils down to personal taste, but the Linux folder icons on the right seems better.

If Windows and MacOS gets their latest official icons, it's fair that Linux does too. Plus "yellow" relates to the current kernel icon, sort of 😉 See: https://kernel.org/

SVG files 👇🏻

• 
• 

[md-siam]

joe733 still not fixed. 😒

[yozachar]

Hi @md-siam, it will only be fixed if the PR is merged. I'm neither the PR author nor a repository maintainer. I'm afraid I cannot 'fix' it.

What you can do as a workaround is, download these SVGs:

	Linux	Windows	MacOS
Close
Open

and add the following to your .vscode/setting.json

{
    "material-icon-theme.folders.associations": {
        "linux": "../icons/folder-linux",
        "windows": "../icons/folder-windows",
        "macos": "../icons/folder-macos",
    }
}

But, in my system it's still vanishing, maybe try at your end a see.

---

@PKief I understand now, that the icon I suggested earlier was not part of Material Design Icon pack. But the ones I've put forward in this comments (see above table) conforms the both to material icons and colors. Please review.

[md-siam]

joe733 Thanks for the temporary solution. 👍

[Keeryel]

Surprising this branch hasn’t been pushed to the base branch yet

[PKief]

Hi @md-siam, it will only be fixed if the PR is merged. I'm neither the PR author nor a repository maintainer. I'm afraid I cannot 'fix' it.

What you can do as a workaround is, download these SVGs:
...

I've just added these icons to this PR. I think they look great. Thanks for the creation of these SVGs and thanks for being patient 🙂