Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add support to gatsby-config.ts #1672

Merged
merged 2 commits into from
Aug 29, 2022
Merged

fix: add support to gatsby-config.ts #1672

merged 2 commits into from
Aug 29, 2022

Conversation

lgxm3z
Copy link
Contributor

@lgxm3z lgxm3z commented Aug 28, 2022

image

PKief
PKief requested changes Aug 28, 2022
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why you're removing the file extension for JavaScript? We should add a new line for 'gatsby.config.ts',.

@lgxm3z
Copy link
Contributor Author

lgxm3z commented Aug 28, 2022

I made a mistake, I thought the .js line was duplicated

@lgxm3z
Copy link
Contributor Author

lgxm3z commented Aug 28, 2022

I made a mistake, I thought the .js line was duplicated

Actually I think it was, and replacing "-" with "."

According to the documentation only gatsby-config.js and gatsby-config.ts are valid

image

The .js extension is still there...

image

@lgxm3z lgxm3z requested a review from PKief August 28, 2022 21:12
PKief
PKief approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me :)

@PKief PKief merged commit 2ad0fe2 into material-extensions:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lgxm3z @PKief