-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update drone logotype #1698
feat: Update drone logotype #1698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
25545f4
to
c3dad56
Compare
Sure thing, updated it now to include some padding. I went with approximately 6.5% of width/height on each side, which seems close to what some other icons use. Maybe it could be good to add something along the lines of "please include X% padding around any icon" to the contribution guidelines to keep it consistent for new additions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the adjustments! Just noticed that there's only one thing missing. I usually try to avoid using the colors #000
and #fff
as colors. This is because they are either too bright or too dark and the contrast to other icons is too strong. Could you please replace the white color of the drone.svg icon with another color of the blue-grey color?
PS: You're right, I should mention this somewhere in the contribution guide :)
Sure thing, it has been fixed. Maybe this (as well as the padding mentioned) is a good addition to the contribution guidelines, to help create better pull requests going forward :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing the new icons, they are looking nice now :)
Thank you for your work on this extension man! |
* feat: update drone to new logotype * fix: update color to material color through converter * style: add some padding * fix: don't use pure white as fill color * Update drone icons Co-authored-by: Philipp Kief <philipp.kief@gmx.de>
Resolves https://github.com/PKief/vscode-material-icon-theme/issues/1697