Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update drone logotype #1698

Merged
merged 5 commits into from
Sep 26, 2022

Conversation

JonatanLindstrom
Copy link
Contributor

@PKief PKief self-requested a review September 26, 2022 05:21
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new logo looks nice! I was wondering if you could add some additional space around the icon? I mean as it was around the old icon too:

image

@JonatanLindstrom
Copy link
Contributor Author

Sure thing, updated it now to include some padding. I went with approximately 6.5% of width/height on each side, which seems close to what some other icons use.

Maybe it could be good to add something along the lines of "please include X% padding around any icon" to the contribution guidelines to keep it consistent for new additions?

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustments! Just noticed that there's only one thing missing. I usually try to avoid using the colors #000 and #fff as colors. This is because they are either too bright or too dark and the contrast to other icons is too strong. Could you please replace the white color of the drone.svg icon with another color of the blue-grey color?

image

PS: You're right, I should mention this somewhere in the contribution guide :)

@JonatanLindstrom
Copy link
Contributor Author

Sure thing, it has been fixed.

Maybe this (as well as the padding mentioned) is a good addition to the contribution guidelines, to help create better pull requests going forward :)

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the new icons, they are looking nice now :)

@PKief PKief merged commit 46aa2d0 into material-extensions:main Sep 26, 2022
@JonatanLindstrom JonatanLindstrom deleted the drone-logotype branch September 27, 2022 05:44
@JonatanLindstrom
Copy link
Contributor Author

Thank you for your work on this extension man!

Anselmoo pushed a commit to Anselmoo/vscode-material-icon-theme that referenced this pull request Nov 5, 2022
* feat: update drone to new logotype

* fix: update color to material color through converter

* style: add some padding

* fix: don't use pure white as fill color

* Update drone icons

Co-authored-by: Philipp Kief <philipp.kief@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Update] Drone logotype is outdated
2 participants