change error messages for Opacity and Saturation (value should be float) #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughlilly
changed the title
Done! I had opened the file by pressing Some repos I’ve worked with in the past have a precommit hook set up to autoformat staged files; would that be worth setting up on this repo to avoid this in the future? |
|
@hughlilly Thanks for the adjustments. To be honest, I'm not a big fan of pre commit hooks. They slow down the Git process and I don't want to have any side effects when I commit something. It was already suggested with this PR https://github.com/PKief/vscode-material-icon-theme/pull/1526/, but as I wrote there, I'm still not very sure about this. |
PKief
approved these changes
Nov 3, 2022
Anselmoo
pushed a commit
to Anselmoo/vscode-material-icon-theme
that referenced
this pull request
Nov 5, 2022
…at) (material-extensions#1746) * changes error messages to specify that value should be floating-point * format with prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests changes to the wording of the error messages when the user attempts to set the values for Opacity or Saturation. The previous wording didn’t make it clear, imo, that the value can be a floating-point number. I went to experiment with these settings and initially thought I could only enter a
1or a0(then wondered why they weren’t Boolean).