Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: werf icon #1995

Merged
merged 3 commits into from Jun 15, 2023
Merged

feat: werf icon #1995

merged 3 commits into from Jun 15, 2023

Conversation

godunko-mikhail
Copy link
Contributor

@godunko-mikhail godunko-mikhail commented Jun 13, 2023

I know that this svg is not the best for material icons, but i really hope that it will be approved because there's no other werf icon support anywhere
#1715

@PKief
Copy link
Owner

PKief commented Jun 13, 2023

What about using the ferry or pier-crane icon here?

@godunko-mikhail
Copy link
Contributor Author

godunko-mikhail commented Jun 13, 2023

I don't think that's a good idea to change the icon, werf has 3.6k stars and we known werf by this icon
https://github.com/werf/werf

@godunko-mikhail
Copy link
Contributor Author

image
In fact it looks pretty

@PKief
Copy link
Owner

PKief commented Jun 13, 2023

Could you please take a look at the contribution guidelines? First the icon should have a proper color and there must be some spacing around the icon.

@godunko-mikhail
Copy link
Contributor Author

Is that all?

@PKief PKief self-requested a review June 14, 2023 14:37
Copy link
Owner

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustments! Now it looks good to me :)

@PKief PKief merged commit 85eaaaf into PKief:main Jun 15, 2023
3 checks passed
@preenx
Copy link

preenx commented Aug 25, 2023

So happy to see werf in my editor <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants