Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon Request] Add icon association to dockercompose language id #2059

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

PKief
Copy link
Member

@PKief PKief commented Aug 21, 2023

Changes

  • Add dockercompose language id to docker icon
  • Remove yml and yaml extensions from file icon association as they will also detected via language id automatically and will not produce a conflict with the compose.*.yaml files

Locally tested and it works automatically:

image

If the automatic detection might not work for some users, they can add this config to their user or workspace settings and it will force VS Code to apply the language id to these files names (interestingly here VS Code supports the glob pattern):

"files.associations": {
    "compose.*.yaml": "dockercompose"
}

And then this extension finally maps the icon to the language id and applies it to all files which are associated with this id.

@PKief PKief self-assigned this Aug 21, 2023
@PKief PKief linked an issue Aug 21, 2023 that may be closed by this pull request
2 tasks
@PKief PKief merged commit e462540 into main Aug 24, 2023
4 checks passed
@PKief PKief deleted the PKief/issue2058 branch August 24, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request] Relax the Docker icon for more YAML files for Docker Compose
1 participant