Added disc file extensions (vmdk, qcow2, etc.) #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
PKief
requested changes
Aug 28, 2023
Co-authored-by: Philipp Kief <philipp.kief@gmx.de>
|
Updated. |
PKief
requested changes
Aug 30, 2023
There was a problem hiding this comment.
Sorry for the strict review but the pipeline is still complaining that you should remove the whitespaces at some places. Typically, I use a formatter (prettier) which automatically updates the format of the code. Not sure how you were editing the code but next time you should install the prettier plugin for VS Code to ensure that you have the proper formatting :)
Co-authored-by: Philipp Kief <philipp.kief@gmx.de>
Co-authored-by: Philipp Kief <philipp.kief@gmx.de>
|
We already have some icons for existing file extensions:
|
|
Thanks for the contribution, merge was successful ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.