Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSpec file icon #2106

Merged
merged 32 commits into from Dec 11, 2023
Merged

Add RSpec file icon #2106

merged 32 commits into from Dec 11, 2023

Conversation

blchelle
Copy link
Contributor

@blchelle blchelle commented Oct 7, 2023

RSpec is a frequently used Behavior Driven Development framework for Ruby on Rails projects.
I'm only associating this icon with files named .rspec which live at the root of any rails project that uses rspec.

@PKief PKief self-assigned this Nov 16, 2023
Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@PKief
Copy link
Owner

PKief commented Nov 18, 2023

@blchelle sorry for the noise, just trying out some workflow improvements, nothing to worry about ;)

@blchelle
Copy link
Contributor Author

@PKief np, do what you need to do

@blchelle
Copy link
Contributor Author

@PKief are you able to merge this?

Copy link
Owner

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you, it looks good to me 👍

@PKief PKief merged commit 245b2fb into PKief:main Dec 11, 2023
4 checks passed
Copy link

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants