Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add icons for PDM #2195

Merged
merged 6 commits into from Jan 30, 2024
Merged

feat: add icons for PDM #2195

merged 6 commits into from Jan 30, 2024

Conversation

GabDug
Copy link
Contributor

@GabDug GabDug commented Jan 17, 2024

Hey 👋

MR to add icons for PDM, Feedback is welcomed :)

Folder icon:

  • Motive: #B39DDB (Deep purple 200)
  • Background: #673AB7 (Deep purple 500)

File icon:

  • Motive: #9575CD (Deep purple 300), close to the original of #AC75D7

Fix #2194

Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@frostming
Copy link

Wow, that is great.

Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@GabDug
Copy link
Contributor Author

GabDug commented Jan 25, 2024

Hey @PKief, do you have any feedback regarding these icons?

Thanks!

Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

Copy link
Owner

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@PKief PKief merged commit 97735d6 into PKief:main Jan 30, 2024
4 checks passed
Copy link

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request] PDM (Python dependency manager)
3 participants