Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added processing(.pde) icon. #229

Closed
wants to merge 1 commit into from
Closed

Added processing(.pde) icon. #229

wants to merge 1 commit into from

Conversation

JotaroS
Copy link
Contributor

@JotaroS JotaroS commented Mar 23, 2018

Hi,
I added Processing (https://processing.org/) icon.
Processing is the under GPLv2 license.
The icon is from the latest version of Processing app.

@JotaroS
Copy link
Contributor Author

JotaroS commented Mar 23, 2018

@PKief Please review, thank you.

@PKief
Copy link
Owner

PKief commented Mar 24, 2018

I would prefer to use two different icons, one for a light background and another one for the dark background. And I think it is better to use no dark circle as a background for this icon. The dark circle as the background will be not visible on a dark background and on a light background it will be to prominent.

It looks more simple and clean if we make it like this:

Light:

processing icon dark background

Dark:

processing icon light background

Would that be okay with you?

@JotaroS
Copy link
Contributor Author

JotaroS commented Mar 24, 2018

@PKief Wow that's fantastic. and yes, I was a bit worried about the background.
How can I do for this? or you do instead?
(If there's any guideline for making dark/light icon that will also be great!)

@PKief
Copy link
Owner

PKief commented Mar 24, 2018

@JotaroS I've already changed the icons and I'll merge your pull request soon. So you don't have to do anything else. But thank you for the pull request at all 😃

@JotaroS
Copy link
Contributor Author

JotaroS commented Mar 24, 2018

Great! Thank you for your help.

PKief added a commit that referenced this pull request Mar 26, 2018
@PKief
Copy link
Owner

PKief commented Mar 26, 2018

Merged with 0c3277d.

@PKief PKief closed this Mar 26, 2018
@JotaroS
Copy link
Contributor Author

JotaroS commented Mar 27, 2018

Vielen Dank!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants