Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ c-family icons improvements #2299

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

lucas-labs
Copy link
Contributor

@lucas-labs lucas-labs commented Apr 22, 2024

Updates all icons for the C-family of languages so that:

  • they look nice together, having a similar style
  • the C in C++ doesn't look like a G when looked at 16px

image

Apart from the changes discused in #2294, I went ahead and also changed C# icon, to have the same shape for the C letter as in the others.

Fixes #2294

Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

Copy link
Owner

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing a PR so soon! Please have a look at the review comment for the hpp file icon. But except of that your changes look very nice from my point of view.

icons/hpp.svg Show resolved Hide resolved
@lucas-labs lucas-labs requested a review from PKief April 22, 2024 22:32
Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@PKief PKief merged commit c9f833e into PKief:main Apr 23, 2024
4 checks passed
Copy link

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

@lucas-labs lucas-labs deleted the pp/c-family branch April 23, 2024 08:21
@lucas-labs lucas-labs restored the pp/c-family branch April 23, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New cpp icon
2 participants