Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new folder icons #339

Merged
merged 14 commits into from Nov 1, 2018
Merged

Conversation

AdrieanKhisbe
Copy link
Contributor

Adding a bunch of new icons folder to the already awesome collections.
List was based on needs and issues #218, #205 and #301.

Here is the list of new icons

  • api
  • app
  • archive
  • batch
  • cluster
  • command
  • constant
  • container
  • content
  • core
  • delta
  • dump
  • environment
  • functions
  • generated
  • hook
  • job
  • keys
  • layout
  • mail
  • mappings
  • meta
  • packages
  • shared
  • stack
  • template
  • utils

And here a sample screenshot:

capture d ecran 2018-10-31 a 08 36 13

Colors, and also icons are of course open to discussion =)

@AdrieanKhisbe
Copy link
Contributor Author

(Some color should be adjusted I thinks, api notably. But I prefer to receive feedbacks first =) )

@PKief
Copy link
Owner

PKief commented Oct 31, 2018

Wow, I'm very impressed, I like the icons very much 👍


I would like to spend some time adjusting the colors so that the icons fit perfectly to the existing ones.
Most of the folder icons in the theme look consistent because of the colors. I try to explain it shortly:

  1. The small icons in the lower right corner are usually colored with a hue of 100 (sometimes with 50, if the contrast is not as good as with 100)

folder icon colors

  1. The folder icon in the background is usually darker than the icon in the foreground. It's not fixed to 300 but I try to use a color of the upper half (200-500). It shouldn't be too dark.

  2. These points are no strict rules, but they help to keep the icons consistent 😄
    There are also exceptions, e.g.:

exceptions with the folder icons


But the biggest part of the icon creation is already done thanks to your help, we just need to improve the colors a bit. Thank you very very much 👍

@AdrieanKhisbe
Copy link
Contributor Author

Cool You like it! 😃
I'll try to tweak a bit the color based on your guidelines. =)

@AdrieanKhisbe
Copy link
Contributor Author

Et voilà!
icons

I had some trouble with the app and api that I tried to make yellowish

@PKief
Copy link
Owner

PKief commented Nov 1, 2018

I improved some icons and their colors:

new folder icons

@PKief PKief merged commit d75083f into PKief:master Nov 1, 2018
PKief added a commit that referenced this pull request Nov 1, 2018
PKief added a commit that referenced this pull request Nov 1, 2018
PKief added a commit that referenced this pull request Nov 1, 2018
PKief added a commit that referenced this pull request Nov 1, 2018
@PKief PKief mentioned this pull request Nov 1, 2018
@AdrieanKhisbe AdrieanKhisbe deleted the adding-new-folder-icons branch November 2, 2018 03:42
@AdrieanKhisbe
Copy link
Contributor Author

@PKief Awesome! :)

@mallowigi
Copy link

I wonder, what do you put inside delta, cluster, batch or meta?

PKief added a commit that referenced this pull request Nov 16, 2018
@ghost ghost mentioned this pull request Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants