-
-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add netlify, pnpm, gridsome and eleventy icons #518
Conversation
@PKief anything I can do to help with this? |
It's a good idea of you, but it's the intention that the columns of the table should always be filled down to the bottom, because it simply looks nicer that way, even if sometimes some icons can't be displayed. In general, it is much easier if you could create a separate pull request for each change. If a lot of things are changed in a single pull request, it makes the review much more cumbersome. If there is something in this single pull request that doesn't fit, everything can't be merged, even if there may be good things in it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, nearly all of the icons have a transparent motive so that the background shines through
e.g.
The white "G" is not transparent:
This is important to have a good consistency to the other icons in the theme.
The icon also seems to have a gradient which is not that common in the Material Design Pattern. It would be great if you could check, if it also works without the gradient.
All good. Will open individual PRs with the changes later and we can take it from there. Thank you! |
This PR:
Closes #399.