Add icon for Dhall programmable configuration language #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The logo in question was merged in dhall-lang/dhall-lang@d88b312 and as such is no longer "upcoming," but now official. |
…erial-icon-theme into SiriusStarr-add-dhall
…n-theme into SiriusStarr-add-dhall
PKief
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
Hi @SiriusStarr, I recently added a Dhall icon in commit 1dffab9. I used the pen-tip icon of the materialdesignicon repository because I think that it both represents the official dhall icon and fits to the other material icons very well. But still I want to merge your pull request because of the file extensions that you provided. This is why I updated the icon of this pull request. However, thank you very much for your contribution 👍
|
@PKief Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icon is sourced from the (upcoming) Dhall icon here dhall-lang/dhall-lang#803 with color tweaked slightly to match material design color
Gray #800(#484848->#424242).