Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dune and Opam icons #707

Merged
merged 5 commits into from May 29, 2020
Merged

Added Dune and Opam icons #707

merged 5 commits into from May 29, 2020

Conversation

EduardoAraujoB
Copy link
Contributor

Resolves #706

@ghost
Copy link

ghost commented Apr 30, 2020

I've made a PR to your fork, which will use material icons and not embed a PNG - EduardoAraujoB#1

@PKief PKief self-requested a review May 16, 2020 10:07
@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazingly good! I like it.

@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks also very good! Thank you!

@@ -896,6 +896,8 @@ export const fileIcons: FileIcons = {
{ name: 'dhall', fileExtensions: ['dhall', 'dhallb'] },
{ name: 'sml', fileExtensions: ['sml', 'mlton', 'mlb', 'sig', 'fun', 'cm', 'lex', 'use', 'grm'] },
{ name: 'nrwl', fileNames: ['nx.json'] },
{ name: 'opam', fileExtensions: ['opam'] },
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PKief PKief merged commit d647aa9 into PKief:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request] Dune & Opam
2 participants