Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unity icon #758

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Add unity icon #758

merged 2 commits into from
Jun 9, 2020

Conversation

shubham-saudolla
Copy link
Contributor

Fixes #757

@PKief
Copy link
Member

PKief commented Jun 8, 2020

Hi @shubham-saudolla, this icon already exists under the name shaderlab.svg. If you like you can change the pull request, and add the *.unity file extension to the shaderlab icon.

@PKief PKief self-requested a review June 8, 2020 20:36
@shubham-saudolla
Copy link
Contributor Author

@PKief I've changed the pull request.

PKief
PKief approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@PKief PKief merged commit c481a62 into material-extensions:master Jun 9, 2020
@shubham-saudolla shubham-saudolla deleted the dev1 branch June 9, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Icon request] Unity icon
2 participants
@shubham-saudolla @PKief