Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection folder icon #903

Merged
merged 2 commits into from
Dec 6, 2020
Merged

Add connection folder icon #903

merged 2 commits into from
Dec 6, 2020

Conversation

voyyy
Copy link
Contributor

@voyyy voyyy commented Dec 4, 2020

image

image

@PKief PKief self-requested a review December 4, 2020 22:28
@PKief
Copy link
Member

PKief commented Dec 4, 2020

I'd recommend that we make it look like this:

image

Your proposal goes into the right direction but the black motive in front of the folder is way to small to be recognized in the file explorer. In addition the black color does not fit onto the folder icon. So this is why I'd suggest to make it look as shown above.

@voyyy
Copy link
Contributor Author

voyyy commented Dec 5, 2020

Your idea looks much better so please add this.

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback!

@PKief PKief merged commit 4a662a2 into material-extensions:master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants