Added pwa folder icons #939
Conversation
|
The link for the icon colors does not work https://material.io/design/style/color.html#color-color-palette |
|
Thanks, I updated the link :) https://material.io/design/color/the-color-system.html#tools-for-picking-colors |
|
You can also you this tool: |
There was a problem hiding this comment.
I think it would be more intuitive if we had a self-speaking icon instead of writing "PWA". So as a suggestion we could resuse the "client" folder icon for names like "pwa". What do you think about that?
If you like you can check how it looks like with the following VS Code user setting:
"material-icon-theme.folders.associations": {
"pwa": "client
}If it looks good you could update this PR with these changes. Otherwise we could also look for a complete new icon for this. But I think that the "client" folder icon could fit very well in this case.
|
Oh this makes sense to use the client icon folder for a 'pwa-folder'. My inspiration came from this repo: https://github.com/webmaxru/progressive-web-apps-logo Given the fact that PWAs have their own logo, I thought I would add it like this. For example I currently develop a PWA for a client and I just put all the content inside a simple 'pwa' folder and noticed that there is no icon folder for it yet. What do you think? |
|
Btw your color converter is the bomb, I urge you to add it in the contributing guidelines :) |
I understand the reason why you chose this icon. In my opinion it's not so suited to be used in this icon extension. I'd prefer using an icon like "client" which is more intuitive. I think a symbol is so much more intuitive than some letters. |
Really appreciate your feedback :) I added it to the contributing, too. Thanks for the hint. |
|
I understand! Given that this is my first PR ever, will you just close this PR and change the PWA option or how would you like to manage it? |
|
No worries, I can update your PR, so that the contribution is still yours ;) |
Thank you 😊 |
No description provided.