Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.pbm, .pgm, .ppm, .pnm extensions added as image files #989

Merged
merged 3 commits into from
Apr 7, 2021
Merged

.pbm, .pgm, .ppm, .pnm extensions added as image files #989

merged 3 commits into from
Apr 7, 2021

Conversation

pseudo-usama
Copy link
Contributor

@pseudo-usama pseudo-usama commented Mar 31, 2021

There is an entire family of image formats called Netpbm which contains these icons .pbm, .pgm, .ppm, .pnm. Wikipedia

PPM is an image file format. Used to store image as numbers instead of bytes.
@PKief PKief self-requested a review March 31, 2021 05:42
There is an entire family of image formats called Netpbm. Source [ https://en.wikipedia.org/wiki/Netpbm ]
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additions, but pbm is already registered as file extension for the image icon. Please remove this duplicated file extension.

@pseudo-usama pseudo-usama changed the title PPM(Portable Pixel Map) extension added as image file .pbm, .pgm, .ppm, .pnm extensions added as image files Apr 7, 2021
@pseudo-usama pseudo-usama requested a review from PKief April 7, 2021 15:45
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, now it looks very good!

@PKief PKief merged commit 93c4d16 into material-extensions:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants