Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Reporting while Parsing #158

Closed
ghaith opened this issue Apr 1, 2021 · 1 comment · Fixed by #187
Closed

Error Reporting while Parsing #158

ghaith opened this issue Apr 1, 2021 · 1 comment · Fixed by #187
Assignees
Labels
enhancement New feature or request
Projects

Comments

@ghaith
Copy link
Collaborator

ghaith commented Apr 1, 2021

Is your feature request related to a problem? Please describe.
The parser currently exits on first error, this leads to the cases where the user has to compile multiple times to get to cover all issues.

Describe the solution you'd like
It would be nice if the parser continued parsing and reported all errors at the end.
For this to work, the parser needs to recover when encountering an unexpected token.
A naieve strategy to start with would be to just append whatever token we were expecting and move on.

We have to make sure an invalid parse result will not be sent for generation.

@ghaith ghaith added the enhancement New feature or request label Apr 1, 2021
@ghaith ghaith added this to To do in Next via automation May 25, 2021
@ghaith ghaith moved this from To do to In progress in Next May 25, 2021
@riederm
Copy link
Collaborator

riederm commented Jul 15, 2021

closed by #187

@ghaith ghaith closed this as completed Jul 26, 2021
Next automation moved this from In progress to Done Jul 26, 2021
@ghaith ghaith linked a pull request Jul 26, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Next
Done
Development

Successfully merging a pull request may close this issue.

2 participants