Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser recovery #187

Merged
merged 1 commit into from
Jul 17, 2021
Merged

Parser recovery #187

merged 1 commit into from
Jul 17, 2021

Conversation

riederm
Copy link
Collaborator

@riederm riederm commented Jul 15, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #187 (48042a0) into master (8ae702a) will decrease coverage by 0.07%.
The diff coverage is 94.88%.

❗ Current head 48042a0 differs from pull request most recent head 5adc3e8. Consider uploading reports for the commit 5adc3e8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   95.62%   95.54%   -0.08%     
==========================================
  Files          44       47       +3     
  Lines       19629    21037    +1408     
==========================================
+ Hits        18770    20100    +1330     
- Misses        859      937      +78     
Impacted Files Coverage Δ
src/codegen/tests.rs 92.85% <ø> (ø)
src/compile_error.rs 23.80% <0.00%> (-1.84%) ⬇️
src/parser/tests/expressions_parser_tests.rs 99.28% <ø> (-0.02%) ⬇️
src/ast.rs 87.78% <47.61%> (+0.84%) ⬆️
src/lib.rs 40.22% <55.40%> (+7.84%) ⬆️
src/parser/control_parser.rs 91.89% <83.56%> (-7.59%) ⬇️
src/parser/expressions_parser.rs 97.05% <87.37%> (-2.05%) ⬇️
...tests/parse_errors/parse_error_containers_tests.rs 88.11% <88.11%> (ø)
src/parser.rs 96.93% <97.20%> (-0.42%) ⬇️
src/lexer.rs 32.72% <98.66%> (+7.94%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae702a...5adc3e8. Read the comment docs.

src/lexer.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/parser.rs Outdated Show resolved Hide resolved
src/parser/tests/parser_tests.rs Outdated Show resolved Hide resolved
ghaith
ghaith previously approved these changes Jul 17, 2021
added additional parse_error tests

restructure parse-error test into submodules

improve further error recovery with VAR-blocks

Add initial syntax error reporting

empty statements are parsed correctly

code-gen ignores empty-statements

improve error-recovery in regions (IF statements)
improve error-recovery in regions (FOR-Loops)
improve error-recovery in regions (REPEAT)
improve error-recovery in regions (WHILE)

Add recovery for case statements
fix end-pou keyword problems
remove unused features (newlines, path)
sourcerange.filepath, new-line-information
@ghaith ghaith merged commit 9c334e7 into master Jul 17, 2021
@ghaith ghaith deleted the parser_recovery branch July 17, 2021 14:13
@ghaith ghaith linked an issue Jul 26, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Reporting while Parsing
2 participants