Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility: Expression-List as Array-Initialization #352

Closed
riederm opened this issue Oct 29, 2021 · 1 comment · Fixed by #394
Closed

Compatibility: Expression-List as Array-Initialization #352

riederm opened this issue Oct 29, 2021 · 1 comment · Fixed by #394
Assignees
@99NIMI
Labels
compatibility-oscat syntax or semantics which are not necessarily part of the standard, but seen in the oscat-libraries good first issue Good for newcomers
Projects
Next
Milestone
oscat

Comments

@riederm
Copy link
Collaborator

riederm commented Oct 29, 2021

There is existing code that uses an Expression-list as an array-initialization and I think we should be compatibilt to this.

	FACTS : ARRAY[0..12] OF DINT := 1,1,2,6,24,120,720,5040,40320,362880,3628800,39916800,479001600;

this code is from oscat basic library.
@riederm riederm added the compatibility-oscat syntax or semantics which are not necessarily part of the standard, but seen in the oscat-libraries label Oct 29, 2021
@ghaith ghaith added this to the oscat milestone Oct 29, 2021
@riederm riederm added the good first issue Good for newcomers label Nov 29, 2021
@99NIMI 99NIMI added this to To do in Next via automation Nov 30, 2021
@99NIMI 99NIMI moved this from To do to In progress in Next Dec 1, 2021
@99NIMI 99NIMI self-assigned this Dec 1, 2021
@create-issue-branch
Copy link

Branch issue-352-Compatibility_Expression-List_as_Array-Initialization created!

99NIMI added a commit that referenced this issue Dec 2, 2021
@99NIMI
expression list arr initialization for int (#352)
82f235b
99NIMI added a commit that referenced this issue Dec 2, 2021
@99NIMI
expression list arr init for string (#352)
a3eae6f
99NIMI added a commit that referenced this issue Dec 2, 2021
@99NIMI
expression list arr init containing binaryexpression (#352)
8a22161
@99NIMI 99NIMI linked a pull request Dec 2, 2021 that will close this issue
Issue 352 compatibility expression list as array initialization #394
Merged
@99NIMI 99NIMI moved this from In progress to Review in progress in Next Dec 2, 2021
Next automation moved this from Review in progress to Done Dec 3, 2021
ghaith pushed a commit that referenced this issue Dec 3, 2021
@99NIMI
Issue 352 compatibility expression list as array initialization (#394)
8407135 
* expression list arr initialization for int (#352)

* expression list arr init for string (#352)

* expression list arr init containing binaryexpression (#352)

* added tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@99NIMI 99NIMI

Labels
compatibility-oscat syntax or semantics which are not necessarily part of the standard, but seen in the oscat-libraries good first issue Good for newcomers
Projects
Next
Status: Done
Next
Done
Milestone
oscat
Development

Successfully merging a pull request may close this issue.

Issue 352 compatibility expression list as array initialization PLC-lang/rusty
3 participants
@ghaith @riederm @99NIMI