Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOD-Literal can only be parsed if it has 3 sections #355

Closed
riederm opened this issue Oct 29, 2021 · 3 comments · Fixed by #360
Closed

TOD-Literal can only be parsed if it has 3 sections #355

riederm opened this issue Oct 29, 2021 · 3 comments · Fixed by #360
Assignees
@99NIMI
Labels
compatibility-oscat syntax or semantics which are not necessarily part of the standard, but seen in the oscat-libraries good first issue Good for newcomers
Projects
Next

Comments

@riederm
Copy link
Collaborator

riederm commented Oct 29, 2021

the oscat-basic library contains TOD literals with only 2 sections. We currently fail parsing these:

TOD#12:00 should be treated as TOD#12:00:00
@riederm riederm added the compatibility-oscat syntax or semantics which are not necessarily part of the standard, but seen in the oscat-libraries label Oct 29, 2021
@riederm
Copy link
Collaborator Author

riederm commented Oct 29, 2021

we should also consider more flexible versions of all the other time-literals

@riederm riederm added the good first issue Good for newcomers label Oct 29, 2021
@riederm
Copy link
Collaborator Author

riederm commented Oct 29, 2021

the regex really wants 3 segments

rusty/src/lexer/tokens.rs

Line 347 in 1cc6dd6

#[regex("(TIME_OF_DAY|TOD)#\\d+:\\d+:\\d+(\\.\\d+)?", ignore(case))]

die Funktionen parse_literal_date... im expression_parser.rs erwarten jetzt natürlich genau diese komponenten. Diese müssen auch angepasst werden.

@99NIMI 99NIMI added this to To do in Next via automation Nov 3, 2021
@99NIMI 99NIMI self-assigned this Nov 3, 2021
@create-issue-branch
Copy link

Branch issue-355-TOD-Literal_can_only_be_parsed_if_it_has_3_sections created!

@99NIMI 99NIMI moved this from To do to In progress in Next Nov 3, 2021
99NIMI added a commit that referenced this issue Nov 3, 2021
@99NIMI
TOD literlas can now be parsed with 2 and 3 sections (#355)
2def89d
@99NIMI 99NIMI moved this from In progress to Review in progress in Next Nov 3, 2021
@99NIMI 99NIMI linked a pull request Nov 3, 2021 that will close this issue
TOD literlas can now be parsed with 2 and 3 sections (#355) #360
Merged
99NIMI added a commit that referenced this issue Nov 4, 2021
@99NIMI
support DATE_AND_TIME with only 2 sections (#355)
ee2a065
Next automation moved this from Review in progress to Done Nov 5, 2021
99NIMI added a commit that referenced this issue Nov 5, 2021
@99NIMI
Merge pull request #360 from PLC-lang/issue-355-TOD-Literal_can_only_…
4dd88ca 
…be_parsed_if_it_has_3_sections

TOD literlas can now be parsed with 2 and 3 sections (#355)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@99NIMI 99NIMI

Labels
compatibility-oscat syntax or semantics which are not necessarily part of the standard, but seen in the oscat-libraries good first issue Good for newcomers
Projects
Next
Status: Done
Next
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TOD literlas can now be parsed with 2 and 3 sections (#355) PLC-lang/rusty
2 participants
@riederm @99NIMI