un-initialized constants report unresolved constant variable while they should get their default value

[rarris]

program example

FUNCTION main : DINT
    VAR CONSTANT
    	cmd1 : commands;
        var2 : INT;
    END_VAR

END_FUNCTION

TYPE commands :
STRUCT
	ReInit : BOOL;
	Reset : BOOL;
	Stop : BOOL;
END_STRUCT
END_TYPE

error: Unresolved constant 'cmd1' variable
┌─ test.st:19:6
│
19 │ cmd1 : command;
│ ^^^^^

error: Unresolved constant 'var2' variable
┌─ test.st:20:6
│
20 │ var2 : int;
│ ^^^^^

[riederm]

cmd1 & var2 need an initial value - the compiler message is really bad. We should improve the error message for this situation. Or do you think this code should work like this? the constants never get a value - or should they get default values?

[riederm]

by the way - there is a typo I fixed so be careful when you test this again: I changed cmd1: command to cmd1: commands (adding the s in the end).

so the code would work like this:

FUNCTION main : DINT
    VAR CONSTANT
    	cmd1 : commands;
        var2 : INT;
    END_VAR

END_FUNCTION

TYPE commands :
STRUCT
	ReInit : BOOL;
	Reset : BOOL;
	Stop : BOOL;
END_STRUCT
END_TYPE

[ghaith]

Uninitialized constants should also get the default value. I've seen code that defines an uninitialized STRUCT as a "Reset" constant to easily reset other values during execution.

[ghaith]

This is still not solved, the code in the example still fails on codegen (Struct init does not get an initial value)