fix: false-positive downcast warnings #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1114 +/- ##
==========================================
+ Coverage 95.59% 95.63% +0.04%
==========================================
Files 148 148
Lines 43500 43585 +85
==========================================
+ Hits 41583 41684 +101
+ Misses 1917 1901 -16 ☔ View full report in Codecov by Sentry. |
Fixes false-positive downcast warnings on integrally promoted expressions. This is achieved by checking each element's type in the expression individually and comparing it to the resulting type rather than checking the expression's type as a whole.
these tests try to trick the validator to believe that a DINT updscale is happening.
riederm
requested changes
Mar 6, 2024
riederm
reviewed
Mar 6, 2024
mhasel
commented
Mar 11, 2024
|
@riederm when you get the chance, could you please take a look at the changes I've made since your last review? |
riederm
requested changes
Mar 18, 2024
riederm
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes false-positive downcast warnings on integrally promoted expressions. This is achieved by checking each element's type in the expression individually and comparing it to the resulting type rather than checking the expression's type as a whole and mirrors the behaviour of CodeSys.
resolves #828