DATE, DATE_AND_TIME, TIME, TIME_OF_DAY #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added Date-lexer token added LiteralDate AST-element added Date-datatype which internally is an i64 LiteralDates generate i64 literals
added DateAndTime-lexer token added LiteralDateAndTime AST-element added DateAndTime-datatype which internally is an i64 LiteralDateAndTime generate i64 literals
added LiteralTime-lexer token added LiteralTime AST-element added TIME-datatype which internally is an i64 (ms) LiteralTime generates i64 literals
added LiteralTimeOfDay-lexer token added LiteralTimeOfDay AST-element added TIME_OF_DAY-datatype which internally is an DATE_AND_TIME fixed to 1970-01-01
riederm
commented
May 2, 2021
| hour, | ||
| min, | ||
| sec, | ||
| milli, |
| } => self.llvm.create_const_int( | ||
| self.index, | ||
| &Some(self.llvm.i64_type().into()), | ||
| format!("{}", calculate_time_micro(*day, *hour, *min, *sec, *milli)).as_str(), |
src/lexer.rs
Outdated
| #[regex("(TIME_OF_DAY|TOD)#\\d+:\\d+:\\d+(.\\d+)?")] | ||
| LiteralTimeOfDay, | ||
|
|
||
| #[regex("(T(IME)?|t(ime)?)#(\\d+(.\\d+)?(d|h|ms|m|s))+")] |
There was a problem hiding this comment.
remove case insensitivity ... either go all in or nothing
src/lexer/tests/lexer_tests.rs
Outdated
| @@ -264,6 +264,56 @@ fn real_literals_test() { | |||
| lexer.advance(); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn date_literals_test() { | |||
| let mut lexer = lex("DATE#1984-10-01 D#1-1-1"); | |||
There was a problem hiding this comment.
add more rainy day tests (e.g only 2 segments)
| let location = lexer.location(); | ||
| //get rid of D# or DATE# | ||
| let slice = slice_and_advance(lexer); | ||
| let hash_location = slice.find('#').unwrap_or_default(); |
There was a problem hiding this comment.
also go with unwrap()
add comment why it is safe to call unwrap
src/parser/expressions_parser.rs
Outdated
| hour, | ||
| min, | ||
| sec, | ||
| milli: 0, |
There was a problem hiding this comment.
fraction of seconds allowed
add tests
src/parser/expressions_parser.rs
Outdated
| let mut chars = slice.char_indices(); | ||
| let mut curr = chars.next(); | ||
|
|
||
| let mut values = [0.0f64, 0.0, 0.0, 0.0, 0.0]; |
There was a problem hiding this comment.
optimize (remove writes-array)
| } | ||
|
|
||
| #[test] | ||
| fn literal_time_test() { |
There was a problem hiding this comment.
add tests for negative time
add tests for fractions
add tests for ns
| let lexer = super::lex( | ||
| " | ||
| PROGRAM exp | ||
| t#; |
src/typesystem.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// Create the DATE_AND_TIME's DataType description |
There was a problem hiding this comment.
also add documentation to book
|
i bumped the version now! ... it was the very first comment ... lol |
ghaith
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supports datatypes, literals
lets discuss how we really should represent the values internally