Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single line variable declarations #226

Merged
merged 7 commits into from
Aug 10, 2021
Merged

Conversation

ulmer-a
Copy link
Collaborator

@ulmer-a ulmer-a commented Aug 6, 2021

Declare multiple variables with the same type in a single line. Closes #204.

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #226 (069bceb) into master (2200c8c) will decrease coverage by 2.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   95.94%   93.51%   -2.44%     
==========================================
  Files          41       34       -7     
  Lines       15449     9030    -6419     
==========================================
- Hits        14822     8444    -6378     
+ Misses        627      586      -41     
Impacted Files Coverage Δ
src/parser.rs 97.48% <100.00%> (+0.09%) ⬆️
src/lexer/tests/lexer_tests.rs
src/codegen/tests.rs
src/codegen/tests/typesystem_test.rs
src/codegen/tests/codegen_error_messages_tests.rs
src/parser/tests.rs
src/codegen/tests/code_gen_tests.rs

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2200c8c...069bceb. Read the comment docs.

@ulmer-a ulmer-a marked this pull request as ready for review August 6, 2021 18:53
@ulmer-a ulmer-a requested a review from riederm August 6, 2021 18:53
src/parser.rs Show resolved Hide resolved
@ulmer-a
Copy link
Collaborator Author

ulmer-a commented Aug 9, 2021

No idea why coverage went bad :(

@ghaith
Copy link
Collaborator

ghaith commented Aug 10, 2021

How does the coverage look like if we don't ignore tests? I think you can run gcov locally without much changes.

@ulmer-a
Copy link
Collaborator Author

ulmer-a commented Aug 10, 2021

How does the coverage look like if we don't ignore tests? I think you can run gcov locally without much changes.

Ok I think I somewhat know what is going on. Codecov confuses some stuff because of the config changes... However, since the diff coverage is 100% (which is reasonable) I think we can still merge this and actually don't decrease coverage at all.

@ulmer-a ulmer-a requested review from ghaith and removed request for riederm and ghaith August 10, 2021 10:40
@ghaith ghaith merged commit e159877 into PLC-lang:master Aug 10, 2021
@ulmer-a ulmer-a deleted the single_line_vars branch August 10, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "Single Line" variable declarations
2 participants