Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added validation for function return types (#273) #329

Merged
merged 5 commits into from
Oct 18, 2021
Merged

added validation for function return types (#273) #329

merged 5 commits into from
Oct 18, 2021

Conversation

99NIMI
Copy link
Contributor

@99NIMI 99NIMI commented Oct 13, 2021

No description provided.

@99NIMI 99NIMI requested review from ghaith and riederm October 13, 2021 12:02
@99NIMI 99NIMI linked an issue Oct 13, 2021 that may be closed by this pull request
Validation: Invalid Function return types #273
Closed
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021 •
edited
Loading

Codecov Report

Merging #329 (13c5567) into master (eed5b41) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   95.33%   95.39%   +0.05%     
==========================================
  Files          50       50              
  Lines       14409    14439      +30     
==========================================
+ Hits        13737    13774      +37     
+ Misses        672      665       -7
Impacted Files Coverage Δ
src/lib.rs 98.91% <100.00%> (+1.57%) ⬆️
src/parser.rs 97.97% <100.00%> (+0.02%) ⬆️
src/validation.rs 89.65% <100.00%> (ø)
src/validation/pou_validator.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed5b41...13c5567. Read the comment docs.

riederm
riederm reviewed Oct 13, 2021
View reviewed changes
Copy link
Collaborator

@riederm riederm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that returns an enum declared as type not inline?

src/validation/pou_validator.rs Outdated Show resolved Hide resolved
@99NIMI 99NIMI requested a review from riederm October 14, 2021 11:34
ghaith
ghaith reviewed Oct 18, 2021
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@ghaith ghaith self-requested a review October 18, 2021 09:09
@99NIMI 99NIMI merged commit 6145712 into master Oct 18, 2021
@99NIMI 99NIMI deleted the issue-273-Validation_Invalid_Function_return_types branch October 18, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghaith ghaith ghaith approved these changes

@riederm riederm Awaiting requested review from riederm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation: Invalid Function return types
4 participants
@99NIMI @codecov-commenter @ghaith @riederm