Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added architecture design record for enums #496

Merged
merged 3 commits into from
Jun 1, 2022
Merged

added architecture design record for enums #496

merged 3 commits into from
Jun 1, 2022

Conversation

riederm
Copy link
Collaborator

@riederm riederm commented May 31, 2022

No description provided.

@riederm
Copy link
Collaborator Author

riederm commented May 31, 2022

comment from @ghaith: add example with custom numerical type for the enum

@riederm
Copy link
Collaborator Author

riederm commented May 31, 2022

comment from @ghaith: add example with custom numerical type for the enum

introduced an examplary case with BYTE as the enum's type (in enums_constants_are_automatically_numbered_or_user_defined)

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #496 (848fbaf) into master (a0f967e) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   92.89%   92.95%   +0.05%     
==========================================
  Files          39       40       +1     
  Lines       14297    14415     +118     
==========================================
+ Hits        13281    13399     +118     
  Misses       1016     1016              
Impacted Files Coverage Δ
src/tests/adr/pou_adr.rs 100.00% <ø> (ø)
src/tests/adr/enum_adr.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0f967e...848fbaf. Read the comment docs.

@riederm riederm requested a review from ghaith May 31, 2022 18:55
@ghaith ghaith merged commit 29bcbce into master Jun 1, 2022
@ghaith ghaith deleted the adr_enums branch June 1, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants