Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lacp no traffic tests #135

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Add lacp no traffic tests #135

merged 1 commit into from
Jul 3, 2023

Conversation

StepanVovkPLV
Copy link
Collaborator

Signed-off-by: Stepan Vovk stepan.vovk@plvision.eu

Copy link
Collaborator

@SerhiyBoikoPLV SerhiyBoikoPLV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add __init__.py to ./functional/lacp/ folder, because otherwise pytest does not see these LACP tests

@SerhiyBoikoPLV SerhiyBoikoPLV added bug Something isn't working and removed ToUpstream labels Jun 2, 2023
@StepanVovkPLV StepanVovkPLV force-pushed the test_lacp_no_traffic branch 2 times, most recently from c8b5304 to cc207d8 Compare June 7, 2023 11:50
@StepanVovkPLV StepanVovkPLV removed the bug Something isn't working label Jun 7, 2023
@github-actions
Copy link

The pre-commit check detected issues in the files touched by this pull request.

Detailed pre-commit check results:

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for https://github.com/PyCQA/flake8. [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/PyCQA/flake8. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... mixed line ending........................................................Passed trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check for case conflicts.................................................Passed check python ast.........................................................Passed check json...........................................(no files to check)Skipped fix double quoted strings................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 DentOS_Framework/DentOsTestbed/src/dent_os_testbed/test/test_suite/functional/lacp/test_lacp_no_traffic.py:140:39: F541 f-string is missing placeholders
To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3.

2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder

4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>
or
pre-commit run --all-files

@github-actions
Copy link

The pre-commit check detected issues in the files touched by this pull request.

Detailed pre-commit check results:

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for https://github.com/PyCQA/flake8. [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/PyCQA/flake8. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... mixed line ending........................................................Passed trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check for case conflicts.................................................Passed check python ast.........................................................Passed check json...........................................(no files to check)Skipped fix double quoted strings................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 DentOS_Framework/DentOsTestbed/src/dent_os_testbed/test/test_suite/functional/lacp/test_lacp_no_traffic.py:140:39: F541 f-string is missing placeholders
To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3.

2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder

4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>
or
pre-commit run --all-files

Signed-off-by: Stepan Vovk <stepan.vovk@plvision.eu>
@StepanVovkPLV StepanVovkPLV added the PR Created public PR label Jun 23, 2023
@yuriilisovskyi yuriilisovskyi merged commit 3ce6c8f into master Jul 3, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR Created public PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants